Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display interpretation instead of ClinVar ID #3566

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

onursumer
Copy link
Member

@onursumer onursumer commented Jan 7, 2021

Fix cBioPortal/cbioportal#8308
Related to knowledgesystems/signal/issues/78

  • Display clinical significance as the column value
  • Display detailed clinical interpretation (as in the variant view) as a tooltip
  • Linkout (ClinVar ID) in the tooltip as well

ClinVar

@onursumer onursumer requested review from inodb and leexgh January 7, 2021 21:51
@onursumer onursumer force-pushed the clinvar-column branch 3 times, most recently from 498753d to 573529f Compare January 13, 2021 21:09
@onursumer onursumer requested a review from jjgao January 14, 2021 17:44
Copy link
Member

@leexgh leexgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@jjgao jjgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great from ui.

@inodb inodb added automerge automerges with kodiak github app feature labels Jan 22, 2021
@onursumer onursumer force-pushed the clinvar-column branch 3 times, most recently from 1be39c7 to 21d3758 Compare January 26, 2021 21:13
Signed-off-by: Onur Sumer <s.onur.sumer@gmail.com>
@alisman alisman merged commit 401666d into cBioPortal:master Jan 27, 2021
@onursumer onursumer deleted the clinvar-column branch July 2, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerges with kodiak github app feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ClinvarID to ClinVar
5 participants